-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build msquic in a separate docker stage #1064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The change seems to miss
Not sure if that was intentional but unless we install the libraries to standard location or unless we modify library search packages and tests will not be able to find it. |
This reverts commit 61298dd.
Yes, this change intentionally uses msquic's install layout directly instead of manually doing the install ourselves. The |
By using separate stages, we do leave the build tree behind. It doesn't get copied into the second stage. The whole point of using two stages is that we get isolation between them, so we don't need to manually delete files or uninstall packages to get back to the "before we tried to build msquic" state. |
This allows us to avoid leaking anything from the msquic build into the alpine image, promotes better caching while iterating on docker images, and provides better clarity.
It also means that we don't need to carefully remove files/packages that are only needed for the msquic build.