[Parameter Capturing] Dynamically configure if the profiler is notification-only #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: This is targeting a feature branch.
This PR introduces a new environment variable (
DotnetMonitor_Profiler_IsMutatingProfiler) that can be set to cause our profiler to be capable of mutating the target process (not-notification-only). This PR only includes the necessary changes to the profiler and not the supporting logic in our managed code.Our
LoadAsNotificationOnlycallback is invoked before profiler initialization has fully occurred so we're unable to leverageICorProfilerto get environment variables. Instead introduce a new helper method that uses platform-specific APIs.Release Notes Entry