Introduce BackgroundService utility class in StartupHook #6655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
May 17, 2024
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/BackgroundService.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
May 21, 2024
...oft.Diagnostics.Monitoring.StartupHook.UnitTests/BackgroundService/BackgroundServiceTests.cs
Outdated
Show resolved
Hide resolved
...oft.Diagnostics.Monitoring.StartupHook.UnitTests/BackgroundService/BackgroundServiceTests.cs
Outdated
Show resolved
Hide resolved
...oft.Diagnostics.Monitoring.StartupHook.UnitTests/BackgroundService/BackgroundServiceTests.cs
Outdated
Show resolved
Hide resolved
...oft.Diagnostics.Monitoring.StartupHook.UnitTests/BackgroundService/BackgroundServiceTests.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
May 21, 2024
schmittjoseph
approved these changes
May 22, 2024
schmittjoseph
merged commit 4e7f726
into
dotnet:feature/parameter-capturing/startup-hook
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the move from HostingStartup to StartupHook we need a mechanism similar to
Microsoft.Extensions.Hosting.BackgroundServiceto manage the lifetime ofParameterCapturingService.This PR adds the
Microsoft.Diagnostics.Monitoring.StartupHook.BackgroundServiceabstract class.ParameterCapturingServicecan derive from it andDiagnosticsBootstrappercan instantiate and start the service. The integration will be part of a separate PR when I'll move all the files to the StartupHook project.Release Notes Entry