Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.x] [Egress providers - S3 store] Add support for service accounts when running dotnet monitor in kubernetes #6659

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #6626 to release/8.x

/cc @schmittjoseph @jwreford99

…unning dotnet monitor in kubernetes (#6626)

* Reference AWSSDK.SecurityToken in the S3 Storage project so that authentication via Open ID connect is possible
It is enough for the project to be referenced for this to work, and there is no reference to it in the code base, because it's existence allows the AWS SDK to work

* Documentation: add docs to cover the use of service accounts for S3

* Update documentation in line with spell checker

Spell checker flagged that Kubernetes should have an uppercase K and to use the American spelling of utilize

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>

* PR Feedback: Add AWSSDK.SecurityToken.dll to the Signing.props file

---------

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>
@github-actions github-actions bot requested a review from a team as a code owner May 16, 2024 17:08
@github-actions github-actions bot added the backport Pull requests that are backports of another pull request label May 16, 2024
@jander-msft
Copy link
Member

This backport is not needed since merges from main should carry it into this branch.

@jander-msft jander-msft deleted the backport/pr-6626-to-release/8.x branch May 16, 2024 17:28
@jwreford99
Copy link
Contributor

@jander-msft just to be clear on this, does this mean that this won't be available on either the nightly builds or the release builds for quite sometime? AFAICT the 8.1 release hasn't been updated for a while, so I just wanted to check if/when I could use this

@jander-msft
Copy link
Member

This change is in the nightly builds for 8.1 and 9.0 right now. We don't have a timeline for 8.1 release yet and 9.0 is in active preview that typically ships with the .NET 9.0 previews (no guarantees around this timing, but this is what we typically aim for). This just missed the 9.0 Preview 4 release that went out last week but should be available in the next preview.

@jwreford99
Copy link
Contributor

Ah okay fab, thanks very much! 😄

@jwreford99
Copy link
Contributor

jwreford99 commented May 21, 2024

@jander-msft I have been hunting around and I cannot for the life of me find these nightly builds.

Would you be able to point me in the right direction so I can get the nightly build and stick it in a Docker file? AFIACT the docker builds that are nightly don't infact represent the bleeding edge, but a lagging point

TIA!

@jander-msft
Copy link
Member

Would you be able to point me in the right direction so I can get the nightly build and stick it in a Docker file? AFIACT the docker builds that are nightly don't infact represent the bleeding edge, but a lagging point

Normally, we have daily builds of .NET Monitor that are then inserted into dotnet/dotnet-docker nightly branch on a daily basis. Occasionally, we pause those insertions to coordinate some activities. We should be resuming the nightly insertions within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull requests that are backports of another pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants