Validate IPC message commandset before acknowledging #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
changed the title
jander-msft
reviewed
May 21, 2024
jander-msft
approved these changes
May 21, 2024
wiktork
reviewed
May 22, 2024
wiktork
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently when we send an IPC command via the profiler, we respond back with a status code that signals the message was received. However this doesn't account for the scenario where the profiler doesn't know how to handle the message's command set, meaning we would have acknowledged the message but then effectively discarded it without informing dotnet-monitor.
This PR updates the notify-only profiler to check if it knows how to handle a message before acknowledging it. If the message is unsupported, we reply with
E_NOT_SUPPORTED. In dotnet-monitor this will be thrown as:Release Notes Entry