Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parameter capturing in no suspend mode. #6778

Conversation

clguiman
Copy link
Contributor

@clguiman clguiman commented Jun 5, 2024

Summary
  • Moved the InProcessFeaturesService registration before the ProfilerService registration because the IEndpointInfoSourceCallbacks need to first reach the in process service so it can set the DotnetMonitor_InProcessFeatures_ParameterCapturing_Enable environment variable which is later checked by the profiler initialization.

  • Reworked ParameterCapturingTests to include the new shouldSuspendTargetApp arg and added tests to verify the new scenarios: CapturesParametersNoSuspend & AppWithStartupHookFailsInNoSuspend.

  • Updated ScenarioRunner.SingleTarget() to support starting the target process befor the monitor process.

  • Updated docs.

Release Notes Entry

@clguiman clguiman requested a review from a team as a code owner June 5, 2024 13:54
… the tool and add a test to verify the feature doesn't work if the startup hook is manually configured.
@clguiman
Copy link
Contributor Author

clguiman commented Jun 6, 2024

I noticed flakiness around the nosuspend tests caused by the DOTNET_STARTUP_HOOKS env var being set on the target app (The ParameterCapturingService might start up before the monitor is ready), so I reworked the ScenarioRunner to support starting the target app before the monitor.
I also added the AppWithStartupHookFailsInNoSuspend test so it's clearly state we don't support this scenario.

@schmittjoseph schmittjoseph merged commit a2c9bfa into dotnet:feature/parameter-capturing/startup-hook Jun 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants