-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable parameter capturing in no suspend mode. #6778
Merged
schmittjoseph
merged 5 commits into
dotnet:feature/parameter-capturing/startup-hook
from
clguiman:dev/clguiman/verify-no-suspend-mode
Jun 6, 2024
Merged
Enable parameter capturing in no suspend mode. #6778
schmittjoseph
merged 5 commits into
dotnet:feature/parameter-capturing/startup-hook
from
clguiman:dev/clguiman/verify-no-suspend-mode
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
approved these changes
Jun 5, 2024
jander-msft
reviewed
Jun 5, 2024
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/Runners/ScenarioRunner.cs
Outdated
Show resolved
Hide resolved
jander-msft
approved these changes
Jun 5, 2024
schmittjoseph
approved these changes
Jun 5, 2024
…iman/verify-no-suspend-mode
jander-msft
approved these changes
Jun 5, 2024
… the tool and add a test to verify the feature doesn't work if the startup hook is manually configured.
I noticed flakiness around the nosuspend tests caused by the |
jander-msft
approved these changes
Jun 6, 2024
schmittjoseph
merged commit Jun 6, 2024
a2c9bfa
into
dotnet:feature/parameter-capturing/startup-hook
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved the
InProcessFeaturesService
registration before theProfilerService
registration because theIEndpointInfoSourceCallbacks
need to first reach the in process service so it can set theDotnetMonitor_InProcessFeatures_ParameterCapturing_Enable
environment variable which is later checked by the profiler initialization.Reworked
ParameterCapturingTests
to include the newshouldSuspendTargetApp
arg and added tests to verify the new scenarios:CapturesParametersNoSuspend
&AppWithStartupHookFailsInNoSuspend
.Updated
ScenarioRunner.SingleTarget()
to support starting the target process befor the monitor process.Updated docs.
Release Notes Entry