Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old test projects #2

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Remove old test projects #2

merged 1 commit into from
Oct 31, 2023

Conversation

captainsafia
Copy link
Member

Hoping to start with a fresh slate on some of these tests:

  • EventBus.Tests: There were no tests in this project.
  • Basket.FunctionalTests: gRPC service is testing in Basket.UnitTests. RedisBasketRepositoryTests can be brought back through functional tests although I think these belong in the application E2E.
  • Catalog.UnitTests: Duplicate the checks that already happen in Catalog.FunctionalTests and don't work correctly because it is not possible to mock the database layer that is used in this service.

@captainsafia captainsafia merged commit b454f5d into main Oct 31, 2023
1 check passed
@captainsafia captainsafia deleted the safia/rm-tests branch September 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant