Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Server reveng does not work with SQL Server 2008 - is this intentional? #11932

Closed
ErikEJ opened this issue May 8, 2018 · 9 comments
Closed

SQL Server reveng does not work with SQL Server 2008 - is this intentional? #11932

ErikEJ opened this issue May 8, 2018 · 9 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Milestone
2.2.0

Comments

@ErikEJ
Copy link
Contributor

ErikEJ commented May 8, 2018

https://github.com/aspnet/EntityFrameworkCore/blob/dev/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs#L269

ErikEJ/SqlCeToolbox#706

https://docs.microsoft.com/en-us/sql/t-sql/functions/concat-transact-sql?view=sql-server-2017
@ErikEJ ErikEJ mentioned this issue May 8, 2018
Closed
@Ronan-Farrell
Copy link

I'm also getting "'CONCAT' is not a recognized built-in function name."

Microsoft SQL Server Standard Edition (64-bit)
10.50.6220 SP3

@ErikEJ
Copy link
Contributor Author

ErikEJ commented May 8, 2018

The CONCAT function was added in SQL Server 2012

@ajcvickers
Copy link
Member

@bricelam @divega Was this intentional? Should we consider reverting for 2.1?

@bricelam
Copy link
Contributor

bricelam commented May 8, 2018 •
edited

Unintentional, but it looks like mainstream support has ended for SQL Server 2008 (and R2)...

@ErikEJ
Copy link
Contributor Author

ErikEJ commented May 8, 2018

Yes, but then you should make an official decision to not support it any longer, and remove ROW_NUMBER paging etc.

@bricelam
Copy link
Contributor

bricelam commented May 8, 2018

I'm also not against fixing it--just wanted to call that out to consider.

@ajcvickers
Copy link
Member

@bricelam I think we should prepare a fix and take it to shiproom. If they say no, then so be it. /cc @divega

@ajcvickers ajcvickers added this to the 2.1.0 milestone May 8, 2018
@bricelam bricelam added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression labels May 8, 2018
@bricelam bricelam mentioned this issue May 8, 2018
Merged
@ajcvickers
Copy link
Member

This is not approved from RTM. We should bring it back for the first patch.

@ajcvickers ajcvickers modified the milestones: 2.1.0, 2.1.1 May 10, 2018
@bricelam bricelam mentioned this issue May 10, 2018
Closed
@bricelam bricelam modified the milestones: 2.1.1, 2.2.0 May 10, 2018
@bricelam
Copy link
Contributor

bricelam commented May 10, 2018 •
edited

Filing #11958 to track porting to 2.1. Fixed in dev.

@ErikEJ ErikEJ mentioned this issue May 19, 2018
Closed
@smitpatel smitpatel mentioned this issue May 22, 2018
Closed
bricelam added a commit that referenced this issue May 29, 2018
@bricelam
SqlServer RevEng: Use concat operators instead of function
1d447bd 
Fixes #11932
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. regression type-bug
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@bricelam @ajcvickers @ErikEJ @Ronan-Farrell