Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ForSqlServerHasIndex with HasIndex #12366

Closed
AndriySvyryd opened this issue Jun 14, 2018 · 2 comments · Fixed by #14641
Closed

Replace ForSqlServerHasIndex with HasIndex #12366

AndriySvyryd opened this issue Jun 14, 2018 · 2 comments · Fixed by #14641
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

See #4846
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 15, 2018
@divega
Copy link
Contributor

divega commented Nov 15, 2018

PostgreSQL 11 now also supports INCLUDE in CREATE INDEX. It seems to work just like the SQL Server feature.

Just posting it here in case we want to revisit our previous decisions around this API.

@khellang
Copy link
Member

Support is being added to Npgsql.EntityFrameworkCore.PostgreSQL here; npgsql/efcore.pg#699

@khellang khellang mentioned this issue Nov 15, 2018
Merged
AndriySvyryd added a commit that referenced this issue Feb 7, 2019
@AndriySvyryd
Make HasIndex generic
25236b5 
Fixes #12366
@AndriySvyryd AndriySvyryd mentioned this issue Feb 7, 2019
Merged
AndriySvyryd added a commit that referenced this issue Feb 7, 2019
@AndriySvyryd
Make HasIndex generic
96957b2 
Fixes #12366
AndriySvyryd added a commit that referenced this issue Feb 7, 2019
@AndriySvyryd
Make HasIndex generic
c71e4da 
Fixes #12366
AndriySvyryd added a commit that referenced this issue Feb 8, 2019
@AndriySvyryd
Make HasIndex generic
7b0f7b3 
Fixes #12366
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 8, 2019
@AndriySvyryd AndriySvyryd reopened this Feb 8, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview3 Feb 22, 2019
@AndriySvyryd AndriySvyryd removed their assignment Feb 28, 2019
@collinstevens collinstevens mentioned this issue Jul 27, 2019
Merged
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview3, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Make HasIndex generic dotnet/efcore
4 participants
@khellang @divega @ajcvickers @AndriySvyryd