Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RelationalDatabaseCreator.HasTables #15997

Closed
ajcvickers opened this issue Jun 7, 2019 · 0 comments · Fixed by #16003
Closed

Expose RelationalDatabaseCreator.HasTables #15997

ajcvickers opened this issue Jun 7, 2019 · 0 comments · Fixed by #16003
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ajcvickers
Copy link
Member

I have been updating the DatabaseErrorPage tests in ASP.NET to use SQLite so as to be more reliable. I found that the tests failed because SQLite easily gets to a state where the database exists but is empty--for example, just opening a connection to a non-existent database can result it it now existing, but empty.

This can be fixed by checking if the database exists but has no tables, like we do for EnsureCreated, but to do that in a provider agnostic way requires the API to be exposed.

ajcvickers added a commit to dotnet/aspnetcore that referenced this issue Jun 7, 2019
In an attempt to make them more reliable.

See also dotnet/efcore#15997
ajcvickers added a commit to dotnet/aspnetcore that referenced this issue Jun 7, 2019
In an attempt to make them more reliable.

See also dotnet/efcore#15997
@ajcvickers ajcvickers self-assigned this Jun 8, 2019
@ajcvickers ajcvickers reopened this Jun 8, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 11, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 11, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant