Skip to content

Exit Dispose early if reader is already disposed #18572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

Exit Dispose early if reader is already disposed #18572

merged 1 commit into from
Oct 25, 2019

Conversation

roji
Copy link
Member

@roji roji commented Oct 24, 2019

Otherwise calling Close followed by Dispose generates an exception internally, bad for perf and for the debugging experience.

Fixes #18307

@roji
Exit Dispose early if reader is already disposed
1c2527e 
Otherwise calling Close followed by Dispose generates an exception
internally, bad for perf and for the debugging experience.

Fixes #18307
@roji roji requested a review from bricelam October 24, 2019 13:29
@roji roji mentioned this pull request Oct 24, 2019
Closed
@roji roji merged commit 6148e6b into release/3.1 Oct 25, 2019
@roji roji deleted the NoMoreDoubleDispose branch October 25, 2019 13:11
@ajcvickers ajcvickers mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bricelam bricelam bricelam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System InvalidOperationException ("Invalid attempt to call NextResult when reader is closed.") in Microsoft.Data.Sqlite
2 participants
@roji @bricelam