Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store options in ServiceProviderCache #19152

Closed
AndriySvyryd opened this issue Dec 3, 2019 · 2 comments · Fixed by #25313
Closed

Store options in ServiceProviderCache #19152

AndriySvyryd opened this issue Dec 3, 2019 · 2 comments · Fixed by #25313
Labels
area-dbcontext breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Dec 3, 2019

By storing the options object in the underlying dictionary with a custom comparer instead of just the hash code allows to correctly resolve hash collisions for different options.

@ajcvickers
Copy link
Member

@AndriySvyryd Isn't this likely to cause a memory leak due to all the references that the options object may have?

@AndriySvyryd
Copy link
Member Author

@ajcvickers The options object is already stored in the corresponding service provider, how would this be different?

@ajcvickers ajcvickers added this to the Backlog milestone Dec 6, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 2, 2020
AndriySvyryd added a commit that referenced this issue Jul 22, 2021
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 22, 2021
@AndriySvyryd AndriySvyryd removed their assignment Jul 22, 2021
AndriySvyryd added a commit that referenced this issue Jul 22, 2021
AndriySvyryd added a commit that referenced this issue Jul 22, 2021
AndriySvyryd added a commit that referenced this issue Jul 22, 2021
AndriySvyryd added a commit that referenced this issue Jul 22, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dbcontext breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants