-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store options in ServiceProviderCache #19152
Labels
area-dbcontext
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
providers-beware
type-enhancement
Milestone
Comments
@AndriySvyryd Isn't this likely to cause a memory leak due to all the references that the options object may have? |
@ajcvickers The options object is already stored in the corresponding service provider, how would this be different? |
AndriySvyryd
added a commit
that referenced
this issue
Jul 22, 2021
AndriySvyryd
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Jul 22, 2021
AndriySvyryd
added a commit
that referenced
this issue
Jul 22, 2021
AndriySvyryd
added a commit
that referenced
this issue
Jul 22, 2021
AndriySvyryd
added a commit
that referenced
this issue
Jul 22, 2021
AndriySvyryd
added a commit
that referenced
this issue
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-dbcontext
breaking-change
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
providers-beware
type-enhancement
By storing the options object in the underlying dictionary with a custom comparer instead of just the hash code allows to correctly resolve hash collisions for different options.
The text was updated successfully, but these errors were encountered: