Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow discriminator properties to have value converter and comparer #19650

Closed
AndriySvyryd opened this issue Jan 20, 2020 · 0 comments · Fixed by #22425
Closed

Allow discriminator properties to have value converter and comparer #19650

AndriySvyryd opened this issue Jan 20, 2020 · 0 comments · Fixed by #22425
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

Or use them properly everywhere.
@AndriySvyryd AndriySvyryd mentioned this issue Jan 20, 2020
Merged
@ajcvickers ajcvickers self-assigned this Jan 21, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Jan 21, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Feb 13, 2020
Closed
@ajcvickers ajcvickers changed the title Validate that the discriminator property doesn't have a value converter or comparer Allow discriminator properties to value converter and comparer Sep 6, 2020
ajcvickers added a commit that referenced this issue Sep 6, 2020
@ajcvickers
Allow discriminator properties to value converter and comparer
99d344c 
Fixes #19650
@ajcvickers ajcvickers mentioned this issue Sep 6, 2020
Merged
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels Sep 6, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0-rc2 Sep 6, 2020
@ajcvickers ajcvickers changed the title Allow discriminator properties to value converter and comparer Allow discriminator properties to have value converter and comparer Sep 6, 2020
ajcvickers added a commit that referenced this issue Sep 7, 2020
@ajcvickers
Allow discriminator properties to value converter and comparer
4195b9d 
Fixes #19650
ajcvickers added a commit that referenced this issue Sep 8, 2020
@ajcvickers
Allow discriminator properties to value converter and comparer (#22425)
3f54048 
Fixes #19650
ajcvickers added a commit that referenced this issue Sep 9, 2020
@ajcvickers
Generate conditionals instead of switch in materializer delegate for …
3bc3866 
…discriminator values that need custom comparison

Part of #19650
@ajcvickers ajcvickers mentioned this issue Sep 9, 2020
Merged
ajcvickers added a commit that referenced this issue Sep 10, 2020
@ajcvickers
Generate conditionals instead of switch in materializer delegate for …
77c16b4 
…discriminator values that need custom comparison (#22470)

Part of #19650
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc2, 5.0.0 Nov 7, 2020
@roji roji mentioned this issue Jan 22, 2024
Open
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Allow discriminator properties to have value converter and comparer dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd