Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityTypeConfiguration annotation #23163

Closed
AndriySvyryd opened this issue Oct 31, 2020 · 5 comments · Fixed by #23563
Closed

EntityTypeConfiguration annotation #23163

AndriySvyryd opened this issue Oct 31, 2020 · 5 comments · Fixed by #23563
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Milestone

Comments

@AndriySvyryd
Copy link
Member

[EntityTypeConfiguration(typeof (BlogConfiguration))]
public class Blog
{
    ...
}
@ajcvickers ajcvickers changed the title EntityTypeCnfiguration annotation EntityTypeConfiguration annotation Oct 31, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Nov 2, 2020
@ajcvickers ajcvickers added consider-for-current-release good first issue This issue should be relatively straightforward to fix. labels Nov 2, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 4, 2020
@kaydotdev
Copy link

I would like to take this one if there're no objections.

@AndriySvyryd
Copy link
Member Author

@antonace Go ahead.

@KaloyanIT
Copy link
Contributor

Hi there,
I've been trying to implement this, but I am stuck at applying the Configuration. Where should I do that?
I tried to create a convention, but I can not get EntityTypeBuilder.

@AndriySvyryd
Copy link
Member Author

@KaloyanIT You can call new EntityTypeBuilder((IMutableEntityType)builder.Metadata) from the convention.

KaloyanIT added a commit to KaloyanIT/efcore that referenced this issue Dec 2, 2020
AndriySvyryd pushed a commit that referenced this issue Dec 8, 2020
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
@AndriySvyryd AndriySvyryd removed their assignment Dec 11, 2021
@markolbert
Copy link

markolbert commented Aug 12, 2022

Gee. and to think I suggested the exact same thing over a year earlier -- with a write-up on implementing it! -- and didn't get any recognition for doing so :(.

Next time I'll push a little harder. And who knows? Maybe those reviewing feature requests will be a little more supportive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution good first issue This issue should be relatively straightforward to fix. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants