Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable options on CREATE DATABASE statements to SQL Azure #2969

Closed
natemcmaster opened this issue Aug 31, 2015 · 5 comments · Fixed by #18201
Closed

Enable options on CREATE DATABASE statements to SQL Azure #2969

natemcmaster opened this issue Aug 31, 2015 · 5 comments · Fixed by #18201
Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@natemcmaster
Copy link
Contributor

Enable SQL Azure users to modify the pricing tier, size, and edition options issue with CREATE DATABASE.

Example:

CREATE DATABASE BroniesCloud
{
     MAXSIZE = 30 GB ;
     EDITION = 'standard' ;
     SERVICE_OBJECTIVE = 'S1' ;
}
@rowanmiller
Copy link
Contributor

EF Team Triage: Agreed this would be good. We originally looked at moving the database creation to be an explicit API call in the first migration for this reason... but it ended up being so different from other migration operations that we abandoned that approach. We should look at making this a first class API (perhaps in OnConfiguring, or an overload of EnsureCreated and ApplyMigrations).

@natemcmaster moving to backlog but perhaps you will need to tackle this for the test work you are doing.

@ajcvickers ajcvickers removed this from the Backlog milestone Sep 8, 2017
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Sep 8, 2017
@ajcvickers
Copy link
Member

We discussed this again in triage and decided to close for now because:

  • EnsureCreated is intended for rapid prototyping and testing where SQL Azure is not usually used
    • Publishing and deployment scenarios will not normally use this mechanism to create the actual database
  • EnsureCreated and Migrations can work with an already created empty database, which means that the desired database can be created in the portal and used with EF
  • We no longer really need this for testing

As always, we will reconsider this with sufficient feedback, and we might consider a PR if it was well written and not intrusive on the normal experience.

@divega
Copy link
Contributor

divega commented Sep 9, 2019

Tentatively assigned to 3.1, subject to approval.

@divega divega removed the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Sep 9, 2019
@divega
Copy link
Contributor

divega commented Sep 22, 2019

Related: #6577. If we add a mechanism in model builder to configure database creation options, we can eventually use it to cover aspects mentioned in that issue as well, including character set, collation, elastic search options, etc.

We may want to consider these issues duplicates, but we are likely do some options in the short term, and then we will want an issue in the backlog for the rest.

@divega
Copy link
Contributor

divega commented Sep 22, 2019

This is approved for 3.1.

@bricelam bricelam removed their assignment Sep 30, 2019
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 3, 2019
@AndriySvyryd AndriySvyryd removed their assignment Oct 3, 2019
@ajcvickers ajcvickers removed this from the 3.1.0 milestone Oct 24, 2019
@ajcvickers ajcvickers added this to the 3.1.0-preview2 milestone Oct 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview2, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants