Scaffolding doesn't work with the latest version of Mono.TextTemplating #32385

testirme · 2023-11-22T06:28:04Z

When I updated all versions to 8, T4 started giving the following error.

error : The type 'Microsoft.EntityFrameworkCore.Metadata.IModel' of the parameter 'Model' did not match the type passed to the template

error : The host parameter 'Model' could not be converted to the type 'System.CodeDom.CodeTypeReference' specified in the template

error : Error running transform: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.BadImageFormatException: Could not load file or assembly 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. Reference assemblies cannot be loaded for execution. (0x80131058)
File name: 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' ---> System.BadImageFormatException: Could not load file or assembly 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
File name: 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60, processorArchitecture=MSIL' ---> System.BadImageFormatException: Cannot load a reference assembly for execution.
   at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
   at Mono.TextTemplating.TemplateAssemblyLoadContext.Load(AssemblyName assemblyName) in /_/Mono.TextTemplating/Mono.TextTemplating/TemplateAssemblyLoadContext.cs:line 64
   at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingLoad(AssemblyName assemblyName)
   at System.Runtime.Loader.AssemblyLoadContext.Resolve(IntPtr gchManagedAssemblyLoadContext, AssemblyName assemblyName)
   at Microsoft.VisualStudio.TextTemplating3837c1b.GeneratedTextTransformation.TransformText()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   --- End of inner exception stack trace ---
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at Mono.TextTemplating.CompiledTemplate.TemplateProcessor.CreateAndProcess(ITextTemplatingEngineHost host, CompiledAssemblyData templateAssemblyData, String templateAssemblyFile, String fullName, CultureInfo culture, String[] referencedAssemblyFiles) in /_/Mono.TextTemplating/Mono.TextTemplating/CompiledTemplate.TemplateExecutor.cs:line 78

Processing 'D:\AKINSOFT\cloud\erpcloud\Libraries\Asnet.Cloud.Data\CodeTemplates\EFCore\DbContext.t4' failed.

The text was updated successfully, but these errors were encountered:

risperdal · 2023-11-22T06:31:06Z

Same here.
I updated all the related ef packages, i updated my t4 templates based on Microsoft.EntityFrameworkCore.Templates .
But the problem is same.
If i remove t4 templates, scaffold is generated correctly.

I am using postgresql.

ajcvickers · 2023-11-22T12:11:15Z

@risperdal Please post your csproj file.

akinsoftyazilim42 · 2023-11-23T07:27:23Z

@risperdal Please post your csproj file.

hello, I have the same problem. the content of my csproj file is as follows. I would be grateful if you can help what we need to do.

Asnet.Cloud.Data.csproj.zip

ErikEJ · 2023-11-23T07:48:59Z

@akinsoftyazilim42 You are not using the version 8 packages:

    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="7.0.9">
    </PackageReference>
    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="7.0.4" />
    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL.Design" Version="1.1.0" />

akinsoftyazilim42 · 2023-11-23T07:56:02Z

I'm very sorry. I had taken it back. Now I'm sending you the problematic version.
Asnet.Cloud.Data.csproj.zip

ajcvickers · 2023-11-23T09:02:52Z

@akinsoftyazilim42 Remove Npgsql.EntityFrameworkCore.PostgreSQL.Design. It's an obsolete package.

testirme · 2023-11-23T10:41:57Z

@akinsoftyazilim42 Remove Npgsql.EntityFrameworkCore.PostgreSQL.Design. It's an obsolete package.

We uninstalled the Npgsql.EntityFrameworkCore.PostgreSQL.Design package, but the error still persists.

akinsoftyazilim42 · 2023-11-23T12:19:19Z

@akinsoftyazilim42 Remove Npgsql.EntityFrameworkCore.PostgreSQL.Design. It's an obsolete package.

yes. i tried it and now i get the same error.

Stroomtang · 2023-11-23T17:43:20Z

Same error here, without using any PostgreSQL libraries.
Used the Upgrade-function of Visual Studio to update my .NET 7 project to .NET 8. Found out that now SQL Date objects are mapped to DateOnly, wanted to change this using a T4 template as shown here, but I get these errors when trying to scaffold my existing DB tables:

error : The type 'Microsoft.EntityFrameworkCore.Metadata.IModel' of the parameter 'Model' did not match the type passed to the template

error : The host parameter 'Model' could not be converted to the type 'System.CodeDom.CodeTypeReference' specified in the template
error : Error running transform: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.MissingMethodException: Method not found: 'System.String Microsoft.EntityFrameworkCore.ScaffoldingModelExtensions.GetDbSetName(Microsoft.EntityFrameworkCore.Metadata.IReadOnlyEntityType)'.
   at Microsoft.VisualStudio.TextTemplating752bc159.GeneratedTextTransformation.TransformText()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   --- End of inner exception stack trace ---
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at Mono.TextTemplating.CompiledTemplate.TemplateProcessor.CreateAndProcess(ITextTemplatingEngineHost host, CompiledAssemblyData templateAssemblyData, String templateAssemblyFile, String fullName, CultureInfo culture, String[] referencedAssemblyFiles) in /_/Mono.TextTemplating/Mono.TextTemplating/CompiledTemplate.TemplateExecutor.cs:line 78

Attached is my .csproj-file: Projectfile.zip

ErikEJ · 2023-11-23T20:25:25Z

Have you tried with a clean set of the latest t4 templates?

Stroomtang · 2023-11-23T21:13:57Z

Have you tried with a clean set of the latest t4 templates?

I did, I didn't use templates before (didn't need it) so they are the latest. The DbContext.t4 starts (after the imports) with

if (!ProductInfo.GetVersion().StartsWith("8.0"))

testirme · 2023-11-24T08:37:02Z

The cause of the error is "Microsoft.VisualStudio.Web.CodeGeneration.Design"

akinsoftyazilim42 · 2023-11-24T08:41:13Z

Thanks for info. ;)

testirme · 2023-11-24T08:43:54Z

Thanks for info. ;)

you are welcome

mehmetbicer · 2023-11-24T08:47:15Z

Thanks for the information, but it didn't work for me.

ajcvickers · 2023-11-24T09:32:09Z

@bricelam Can you take a look at this?

Stroomtang · 2023-11-24T10:23:38Z

Removing the reference to Microsoft.VisualStudio.Web.CodeGeneration.Design fixed it for me.

ajcvickers · 2023-11-27T12:29:07Z

Note for triage: I suspect the issue here is that VS package is bringing Mono.TextTemplating 2.3.1, but EF seems to require 2.2.1.

…lternate key property Fixes #28961 Reverts #30213 for #32385 In #32385, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing that the key was being modified. However, this scenario is very similar to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying. I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make. So overall, I think we should just revert this change, which is what this PR does.

ajcvickers · 2023-12-02T16:13:43Z

Notes for triage:

The underlying issue here is that Mono.TextTemplating 2.2.1 loads the assembly into the default load context, which allows it to use types created by the EF tooling inside the template. An intentional change was made to stop loading the assembly in this way, which, as far as I can tell, makes it incompatible with EF Core's use. This is presumably why we didn't update to the new version. Assigning the types directly generates:

System.InvalidCastException: [A]Microsoft.EntityFrameworkCore.Metadata.Internal.Model cannot be cast to [B]Microsoft.EntityFrameworkCore.Metadata.Internal.Model. Type A originates from 'Microsoft.EntityFrameworkCore, Version=42.42.42.42, Culture=neutral, PublicKeyToken=adb9793829ddae60' in the context 'Default' at location 'C:\local\code\efcore\artifacts\bin\EFCore.Design.Tests\Debug\net8.0\Microsoft.EntityFrameworkCore.dll'. Type B originates from 'Microsoft.EntityFrameworkCore, Version=42.42.42.42, Culture=neutral, PublicKeyToken=adb9793829ddae60' in the context '"" Mono.TextTemplating.TemplateAssemblyLoadContext #1' at location 'C:\local\code\efcore\artifacts\bin\EFCore.Design.Tests\Debug\net8.0\Microsoft.EntityFrameworkCore.dll'.
   at Microsoft.VisualStudio.TextTemplating827e0a4.GeneratedTextTransformation.Initialize()
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   --- End of inner exception stack trace ---
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at Mono.TextTemplating.CompiledTemplate.TemplateProcessor.CreateAndProcess(ITextTemplatingEngineHost host, CompiledAssemblyData templateAssemblyData, String templateAssemblyFile, String fullName, CultureInfo culture, String[] referencedAssemblyFiles) in /_/Mono.TextTemplating/Mono.TextTemplating/CompiledTemplate.TemplateExecutor.cs:line 77

I verified using Reflection calls that loading the assembly as before fixes the issues seen with 2.3.1. See #32495.

We should check with @mhutch that there isn't some simple fix. Beyond that, I think we have a few options here, but none seem great:

Tell users to pin their Mono.TextTemplating package to 2.2.1 when using EF
Do something hacky like in the draft PR
Fork the Mono.TextTemplating and stop taking a dependency on the external package

…lternate key property (#32492) Fixes #28961 Reverts #30213 for #32385 In #32385, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing that the key was being modified. However, this scenario is very similar to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying. I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make. So overall, I think we should just revert this change, which is what this PR does.

…nconstrained alternate key property (#32523) * Revert behavior to throw when attempting to modify an unconstrained alternate key property (#32492) Fixes #28961 Reverts #30213 for #32385 In #32385, an unconstrained alternate key was added to the model purely to make a non-identifying relationship artificially identifying. #30213 attempted to fix this by throwing that the key was being modified. However, this scenario is very similar to the case for a many-to-many join type, where the composite primary key is also not the end of any relationship, but forces the two many-to-one relationships to be identifying. I prepared a PR that would only throw if the key involved is alternate, but on reflection that doesn't seem like an appropriate distinction to make. So overall, I think we should just revert this change, which is what this PR does. * Quirk

mhutch · 2024-01-10T23:52:01Z

I've added an option to Mono.TextTemplating to allow the host to disable the use of AssemblyLoadContext and revert to the old (current) AppDomain behavior.

I have also made some changes to the loading behavior when using AssemblyLoadContext that may fix the underlying issue and make disabling it unnecessary.

If these solve the issue, I can backport to 2.3.x and make a new release.

ajcvickers · 2024-01-22T18:21:38Z

@mhutch I tried first with the latest preview package, and that still failed. But then I built packages locally from your main branch and used those, and all the tests pass even without setting DisableAssemblyLoadContext.

Sorry for being slow to test this, and thanks for the quick fix! As soon as a preview package is available, we can update our main branch, which will allow customers to test with our daily build.

mhutch · 2024-01-23T06:53:25Z

@ajcvickers preview package 3.0.0-preview-0045-g9b6fc72764 is now live

Part of #32385

ajcvickers · 2024-01-25T10:06:37Z

All: If you have been hitting this, then please try out the latest daily build of EF Core and let us know if the problem is fixed.

jcummings2 · 2024-02-09T22:09:46Z

All: If you have been hitting this, then please try out the latest daily build of EF Core and let us know if the problem is fixed.

Do the daily builds now require dotnet 9? I followed the instructions on the linked page but can't seem to get the daily build installed on a dotnet 8 based project

ajcvickers · 2024-02-10T11:34:53Z

@jcummings2 EF9 should not require .NET 9 at this time. If you are seeing an issue with this, can you please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

jcummings2 · 2024-02-12T21:09:52Z

@jcummings2 EF9 should not require .NET 9 at this time. If you are seeing an issue with this, can you please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

I got it to work with .NET 8 but it was a subtle step that is at best implied on the daily builds instructions related to which version to use. Simply pasting the wildcard 9.0.0-* into the .csproj file didn't work but the build process complained about no such version available. In other words, the statement on the instructions that "Using wildcards will cause NuGet to pull the latest daily build whenever packages are restored" didn't seem true in my case.

However, after I went into the NuGet package manager in Visual Studio and selected "Latest prerelease 9.0.0-*" for each package then it would build and run. Maybe I missed a step but hopefully these details will help someone else.

testirme added the customer-reported label Nov 22, 2023

roji mentioned this issue Nov 22, 2023

.Net8 scaffold T4 Template problem npgsql/npgsql#5437

Closed

ajcvickers mentioned this issue Dec 2, 2023

Revert behavior to throw when attempting to modify an unconstrained alternate key property #32492

Merged

ajcvickers added a commit that referenced this issue Dec 2, 2023

Proof of concept for #32385

995ac07

ajcvickers self-assigned this Dec 2, 2023

ajcvickers added type-bug regression area-scaffolding Servicing-consider labels Dec 2, 2023

ajcvickers added the blocked label Dec 5, 2023

ajcvickers changed the title ~~.Net8 PostgreSql scaffold T4 Template problem~~ Scaffolding doesn't work with the latest version of Mono.TextTemplating Dec 6, 2023

This was referenced Dec 6, 2023

Restore option to load assembly into the current AppDomain mono/t4#169

Closed

Microsoft.VisualStudio.Web.CodeGeneration.Design scaffold t4 template problem. #32556

Closed

This was referenced Jan 10, 2024

Add host option to disable AssemblyLoadContext mono/t4#172

Merged

Fix assembly load priorities when using AssemblyLoadContext mono/t4#173

Merged

ajcvickers added a commit that referenced this issue Jan 23, 2024

Update Mono.TextTemplating to new preview package

4c1e4f9

Part of #32385

ajcvickers added a commit that referenced this issue Jan 23, 2024

Update Mono.TextTemplating to new preview package

61b31ae

Part of #32385

ajcvickers mentioned this issue Jan 23, 2024

Update Mono.TextTemplating to new preview package #32895

Merged

ajcvickers removed the blocked label Jan 23, 2024

ajcvickers added a commit that referenced this issue Jan 24, 2024

Update Mono.TextTemplating to new preview package (#32895)

7142497

Part of #32385

ajcvickers added this to the 8.0.x milestone Jan 25, 2024

ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 25, 2024

ajcvickers modified the milestones: 8.0.x, 9.0.0-preview2 Feb 2, 2024

ajcvickers modified the milestones: 9.0.0-preview2, Backlog Feb 29, 2024

ajcvickers removed the Servicing-consider label Apr 2, 2024

ajcvickers modified the milestones: Backlog, 9.0.0-preview1 Apr 2, 2024

ajcvickers closed this as completed Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scaffolding doesn't work with the latest version of Mono.TextTemplating #32385

Scaffolding doesn't work with the latest version of Mono.TextTemplating #32385

testirme commented Nov 22, 2023

risperdal commented Nov 22, 2023

ajcvickers commented Nov 22, 2023

akinsoftyazilim42 commented Nov 23, 2023

ErikEJ commented Nov 23, 2023

akinsoftyazilim42 commented Nov 23, 2023 •

edited

ajcvickers commented Nov 23, 2023

testirme commented Nov 23, 2023

akinsoftyazilim42 commented Nov 23, 2023

Stroomtang commented Nov 23, 2023 •

edited

ErikEJ commented Nov 23, 2023

Stroomtang commented Nov 23, 2023

testirme commented Nov 24, 2023

akinsoftyazilim42 commented Nov 24, 2023

testirme commented Nov 24, 2023

mehmetbicer commented Nov 24, 2023

ajcvickers commented Nov 24, 2023

Stroomtang commented Nov 24, 2023

ajcvickers commented Nov 27, 2023

ajcvickers commented Dec 2, 2023

mhutch commented Jan 10, 2024

ajcvickers commented Jan 22, 2024

mhutch commented Jan 23, 2024

ajcvickers commented Jan 25, 2024

jcummings2 commented Feb 9, 2024

ajcvickers commented Feb 10, 2024

jcummings2 commented Feb 12, 2024 •

edited

Scaffolding doesn't work with the latest version of Mono.TextTemplating #32385

Scaffolding doesn't work with the latest version of Mono.TextTemplating #32385

Comments

testirme commented Nov 22, 2023

risperdal commented Nov 22, 2023

ajcvickers commented Nov 22, 2023

akinsoftyazilim42 commented Nov 23, 2023

ErikEJ commented Nov 23, 2023

akinsoftyazilim42 commented Nov 23, 2023 • edited

ajcvickers commented Nov 23, 2023

testirme commented Nov 23, 2023

akinsoftyazilim42 commented Nov 23, 2023

Stroomtang commented Nov 23, 2023 • edited

ErikEJ commented Nov 23, 2023

Stroomtang commented Nov 23, 2023

testirme commented Nov 24, 2023

akinsoftyazilim42 commented Nov 24, 2023

testirme commented Nov 24, 2023

mehmetbicer commented Nov 24, 2023

ajcvickers commented Nov 24, 2023

Stroomtang commented Nov 24, 2023

ajcvickers commented Nov 27, 2023

ajcvickers commented Dec 2, 2023

mhutch commented Jan 10, 2024

ajcvickers commented Jan 22, 2024

mhutch commented Jan 23, 2024

ajcvickers commented Jan 25, 2024

jcummings2 commented Feb 9, 2024

ajcvickers commented Feb 10, 2024

jcummings2 commented Feb 12, 2024 • edited

akinsoftyazilim42 commented Nov 23, 2023 •

edited

Stroomtang commented Nov 23, 2023 •

edited

jcummings2 commented Feb 12, 2024 •

edited