Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Relational:TypeMapping" annotation name #9913

Closed
ajcvickers opened this issue Sep 27, 2017 · 2 comments
Closed

Change "Relational:TypeMapping" annotation name #9913

ajcvickers opened this issue Sep 27, 2017 · 2 comments
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-bug
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

It was a relational annotation, but it is now a core annotation.
@ajcvickers ajcvickers mentioned this issue Sep 27, 2017
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Sep 29, 2017
@ajcvickers ajcvickers self-assigned this May 17, 2018
@ajcvickers ajcvickers modified the milestones: Backlog, 3.0.0 May 17, 2018
@ajcvickers
Copy link
Member Author

And make the annotation names public and consistent.

@ajcvickers ajcvickers added help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. and removed size~1-day labels Nov 7, 2018
ajcvickers added a commit that referenced this issue Jan 5, 2019
@ajcvickers
Move Relational: from TypeMapping annotation name
046057c 
Fixes #9913
@ajcvickers ajcvickers mentioned this issue Jan 5, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 5, 2019
ajcvickers added a commit that referenced this issue Jan 6, 2019
@ajcvickers
Move Relational: from TypeMapping annotation name
2929122 
Fixes #9913
@ajcvickers ajcvickers mentioned this issue Jan 28, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview2 Feb 6, 2019
@ajcvickers
Copy link
Member Author

Re-opening to ensure breaking change is announced.

@ajcvickers ajcvickers reopened this Feb 6, 2019
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label May 31, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview2, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@bricelam @ajcvickers