Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizable SQL delimeters in tests #12057

Merged
merged 1 commit into from
May 18, 2018
Merged

Allow customizable SQL delimeters in tests #12057

merged 1 commit into from
May 18, 2018

Conversation

AndriySvyryd
Copy link
Member

Make strict floating point comparison in BuiltInDataTypesTestBase optional

Fixes #11929
Fixes #11940

@AndriySvyryd AndriySvyryd requested a review from anpete May 18, 2018 01:05
@ralmsdeveloper
Copy link
Contributor

@AndriySvyryd providers-fyi?

I'm working on the tests in my spare time for @FirebirdSQL .

In an attempt to get closer, the EF Core tests.

@@ -30,7 +30,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
modelBuilder
.Query<OrderQuery>()
.ToQuery(() => Orders
.FromSql("select * from \"Orders\"")
.FromSql("select * from Orders")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these have [] around names?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't need it

…ional

Allow customizable SQL delimeters in tests

Fixes #11929
Fixes #11940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants