Allow specifying online option on MSSQL indexes #13698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will look at this for 3.0. |
The current behavior is fine. We could make some bigger changes to prevent this, but it's not worth it. The workaround is easy--don't call |
|
Rebased onto master assuming that's where 3.0 work is done |
bricelam
approved these changes
Nov 26, 2018
Introduces new `ForSqlServerIsOnline` extension to index builder. There is a breaking change in `EFCore.SqlServer` in form of new property `ISqlServerIndexAnnotations.IsOnline` Fixes #11499
|
(Rebased again to resolve conflict with |
|
This is awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new
ForSqlServerIsOnlineextension to index builder.There is a breaking change in
EFCore.SqlServerin form of new propertyISqlServerIndexAnnotations.IsOnline.Note that enabling/disabling online index creation does trigger a migration even though I believe it has no effect on the resulting index so it's essentially rebuilt for no reason. If this should be avoided I'd like to request a hint on how to achieve that.
Fixes #11499