Correctly set pool size when using AddPooledDbContextFactory #23983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #23889 **Description** AddPooledDbContextFactory (new in 5.0) has a parameter to set the pool size. This value was not being passed down to lower-level config and hence the default pool size is always used. **Customer Impact** The pool size cannot be changed when using the 'AddDbContext' for a factory and pooling. **How found** Customer reported on 5.0. **Test coverage** The test factoring did not test the defaults or overridden values for pool size; this has been added. **Regression?** No; new feature in 5.0. **Risk** Very low.
ajcvickers
changed the title
AndriySvyryd
approved these changes
Jan 26, 2021
roji
pushed a commit
that referenced
this pull request
Feb 12, 2021
* Merged PR 12008: [internal/release/5.0] Feed update
* Update branding to 5.0.4
- update to 5.0.3 SDK
- also update downlevel runtimes
* Update dependencies from https://github.com/dotnet/arcade build 20210209.6 (#24103)
* InMemory: Allow UnaryExpression.Operand to be converted to nullable for LeftJoin (#23984)
* Correctly set pool size when using AddDbContextFactory (#23983)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23889
Description
AddPooledDbContextFactory (new in 5.0) has a parameter to set the pool size. This value was not being passed down to lower-level config and hence the default pool size is always used.
Customer Impact
The pool size cannot be changed when using the 'AddDbContext' for a factory and pooling.
How found
Customer reported on 5.0.
Test coverage
The test factoring did not test the defaults or overridden values for pool size; this has been added.
Regression?
No; new feature in 5.0.
Risk
Very low.