Correct nullability annotation for ReferenceEntry #25591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the situation here is complicated, since ReferenceEntry APIs sometimes returns nullable for TProperty, sometimes not:
IQueryable<TProperty>
where TProperty should never be null.I don't think there's a perfect solution, here are some options with what they mean for the return values of ReferenceEntry.TargetEntry and CurrentValue:
EntityEntry<BlogDetails>?
, goodEntityEntry<BlogDetails>?
, goodBlogDetails
, really badBlogDetails
, goodTProperty?
EntityEntry<BlogDetails>?
, goodEntityEntry<BlogDetails>?
, goodBlogDetails?
, goodBlogDetails?
, badclass?
constraintEntityEntry<BlogDetails?>?
, badEntityEntry<BlogDetails>?
, goodBlogDetails?
, goodBlogDetails
, goodclass?
, since ReferenceEntry.TargetEntry returns that; this means EntityEntry.Entry would return nullable when reached through a nullable reference navigation - not ideal. It would also make ReferenceEntry.Query returnIQueryable<TProperty?>
, which isn't good.Fixes #24659