[6.0.2] Handle duplicate property infos when sorting columns. #26958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26405
Description
If no explicit order is specified we determine the column order partially based on the property declaration order on the CLR types. However for down migrations the snapshot is used and it doesn't have associated CLR types.
Dictionary<string,object>is used as a stand-in and all properties and navigations are mapped to the indexer. When sorting foreign key properties this causes an exception as the same property info is used as the key multiple times.Customer impact
An exception is thrown when creating a migration for a table rename with two or more navigations. There isn't a practical workaround.
How found
Customer report on RC2. 7 reports so far.
Regression
Yes, from 5.0
Testing
This PR adds coverage for this scenario.
Risk
Low; the fix only affects column order in migrations produced during design-time. Quirk mode not added as there isn't a practical way to access the
AppContextused by CLI tools.