Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw if an entity type in table-sharing uses TPC #27988

Merged
merged 1 commit into from
May 11, 2022
Merged

Throw if an entity type in table-sharing uses TPC #27988

merged 1 commit into from
May 11, 2022

Conversation

AndriySvyryd
Copy link
Member

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make ToTable(b => {}) map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947

@AndriySvyryd AndriySvyryd requested a review from a team May 10, 2022 02:07
@AndriySvyryd AndriySvyryd changed the title Throw if table-sharing principal is in TPC and has derived types or the dependent doesn't use TPH Throw if an entity type in table-sharing uses TPC May 10, 2022
@smitpatel
Copy link
Contributor 

[ConditionalFact]

can remove these attributes

Refers to: test/EFCore.SqlServer.FunctionalTests/Query/TPCRelationshipsQuerySqlServerTest.cs:18 in 6af5d92. [](commit_id = 6af5d92, deletion_comment = False)

smitpatel
smitpatel approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AndriySvyryd
Throw if table-sharing principal is in TPC and has derived types or t…
a6d82d1 
…he dependent doesn't use TPH

Don't configure table name for abstract types in TPC that have a corresponding DbSet property
Make `ToTable(b => {})` map the entity type to the default table

Fixes #3170
Fixes #27608
Fixes #27945
Fixes #27947
@AndriySvyryd AndriySvyryd merged commit 979c898 into main May 11, 2022
@AndriySvyryd AndriySvyryd deleted the Issue3170 branch May 11, 2022 23:11
@ajcvickers ajcvickers mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriySvyryd @smitpatel