Ensure that facets specified in the store type name take precedence #29628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #29600. Using a store type name always overrides any other configuration of the type, since it is has ultimate fidelity of what the database supports. Previously, we were overriding facets set in the store type with those configured by data annotations of the model building API. This change uses -1 to represent an explicitly configured "max" length, as opposed to no length configured, which is consistent with ADO.NET and EF6. Filed #29627 to make this first-class.
AndriySvyryd
approved these changes
Nov 30, 2022
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29600.
Using a store type name always overrides any other configuration of the type, since it is has ultimate fidelity of what the database supports. Previously, we were overriding facets set in the store type with those configured by data annotations of the model building API.
This change uses -1 to represent an explicitly configured "max" length, as opposed to no length configured, which is consistent with ADO.NET and EF6. Filed #29627 to make this first-class.