Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s from AppendInsertAndSelectOperations #29678

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

roji
Copy link
Member

@roji roji commented Nov 25, 2022

No description provided.

@roji roji requested a review from a team November 25, 2022 16:35
@ajcvickers
Copy link
Member

@roji

///     Appends SQL for inserting a row to the commands being built, via an INSERT followed by an optional SELECT to retrieve any
///     database-generated values.

Given that two operations may be inserted, isn't the plural correct?

@roji
Copy link
Member Author

roji commented Nov 27, 2022

The way I think the naming here works, we have a single insert operation (corresponding to a single ModificationCommand), implemented via two commands. We could also rename to AppendInsertAndSelectCommands. It's all maybe a bit subtle :)

In any case, AppendInsertAndSelectOperations is inconsistent with AppendUpdateAndSelectOperation and AppendDeleteAndSelectOperation (which don't have s), we should fix that one way or the other (can wait for the executive consistency officer as well).

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let there be consistency!

@roji roji merged commit 1e483d6 into dotnet:main Nov 30, 2022
@roji roji deleted the RemoveS branch November 30, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants