[release/7.0] Avoid infinite loop during foreign key discovery #29850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #29849
Fixes #29826
Description
When there are already two foreign keys using a property the convention erroneously tries to reconfigure another foreign key to use the same property, fails and repeats.
Customer impact
An app with an affected model will hang in an infinite loop. There is no workaround other than removing this convention.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added a test for this scenario
Risk
Low; the fix has limited scope and a quirk mode was added.