Support for DateOnly/TimeOnly for SQL Server #30109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
reviewed
Jan 22, 2023
roji
force-pushed
the
DateTimeOnly
branch
2 times, most recently
from
584591f
to
a844644
Compare
roji
commented
Jan 22, 2023
roji
commented
Jan 22, 2023
|
This is escalating 😄 |
|
@ErikEJ yeah, a little bit... Though I guess that's what it means to have "full support" for these types in EF... |
roji
commented
Jan 24, 2023
| @@ -43,7 +44,8 @@ public SqlServerNetTopologySuiteTypeMappingSourcePlugin(NtsGeometryServices geom | |||
| || (storeTypeName != null | |||
| && _spatialStoreTypes.Contains(storeTypeName)) | |||
| ? (RelationalTypeMapping)Activator.CreateInstance( | |||
| typeof(SqlServerGeometryTypeMapping<>).MakeGenericType(clrType ?? typeof(Geometry)), | |||
| typeof(SqlServerGeometryTypeMapping<>).MakeGenericType( | |||
| clrType is null || clrType == typeof(SqlBytes) ? typeof(Geometry) : clrType), | |||
There was a problem hiding this comment.
@bricelam FYI
This is necessary since we now pass in both CLR type and store name when generating a query string, where before we were only passing in the store type (https://github.com/dotnet/efcore/pull/30109/files#diff-5ff1054f2cb8ec92738024ab01584a00d9f3ac89dd89a92e98489e5e4e486f94R65)
ErikEJ
reviewed
Jan 24, 2023
src/EFCore.SqlServer/Extensions/SqlServerDbFunctionsExtensions.cs
Outdated
Show resolved
Hide resolved
ErikEJ
reviewed
Jan 24, 2023
src/EFCore.SqlServer/Extensions/SqlServerDbFunctionsExtensions.cs
Outdated
Show resolved
Hide resolved
ajcvickers
reviewed
Jan 26, 2023
This was referenced Jan 29, 2023
ajcvickers
approved these changes
Jan 29, 2023
|
Thank you guys for all your hard work on this! |
|
You're very welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24507
/cc @ErikEJ