Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SequentialGuidValueGenerator non-allocating #30649

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Make SequentialGuidValueGenerator non-allocating #30649

merged 2 commits into from
Apr 16, 2023

Conversation

NKnusperer
Copy link
Contributor

The current implementation of SequentialGuidValueGenerator.Next() allocates some heap memory due to byte[] usages. Rewrite this to a Span based version to avoid any allocations. Fixes #30610

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@NKnusperer
Make SequentialGuidValueGenerator non-allocating
9a596af 
The current implementation of `SequentialGuidValueGenerator.Next()` allocates some heap memory due to `byte[]` usages.
Rewrite this to a `Span` based version to avoid any allocations.
Fixes #30610
@NKnusperer
Copy link
Contributor Author

@dotnet-policy-service agree

roji
roji approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/EFCore/ValueGeneration/SequentialGuidValueGenerator.cs Outdated Show resolved Hide resolved
@roji roji merged commit 0386a9b into dotnet:main Apr 16, 2023
@NKnusperer NKnusperer deleted the issues/30610-Make-SequentialGuidValueGenerator-non-allocating branch April 16, 2023 14:57
@ajcvickers ajcvickers mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make SequentialGuidValueGenerator non-allocating
3 participants
@NKnusperer @roji @ajcvickers