Tiny cleanup of CloningExpressionVisitor #30700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Apr 16, 2023
| } | ||
| // join and set operations are fine, because they contain other TableExpressionBases inside, that will get cloned | ||
| // and therefore set expression's Update function will generate a new instance. | ||
| case JoinExpressionBase or SetOperationBase: |
There was a problem hiding this comment.
@maumar note using the base classes for joins/set operations rather than listing them out
There was a problem hiding this comment.
my thinking was that if we introduce new join/set expression that happens to need cloning logic, we would need to explicitly make the decision, rather than being covered by base. But now that I think about it, it was overkill.
There was a problem hiding this comment.
OK. I think your logic (as in the comment) should hold for any subclass of JoinExpressionBase/SetOperationBase... We can see where it goes...
maumar
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to switch and some tiny stuff.