Improve collection indexer normalization #30780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Perform the normalization for core, not just for relational. * Integrate it into QueryableMethodNormalizingExpressionVisitor * Perform it on indexers on any type that implements IReadOnlyList<>, not just List.
* Move normalization of array.Length to Count() from nav expansion to normalization step. * Also normalize array.LongLength.
roji
commented
Apr 27, 2023
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Apr 28, 2023
src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs
Show resolved
Hide resolved
maumar
reviewed
Apr 28, 2023
src/EFCore.SqlServer/Query/Internal/SqlServerDataLengthFunctionTranslator.cs
Outdated
Show resolved
Hide resolved
This reverts commit 0afc465.
roji
commented
Apr 28, 2023
There was a problem hiding this comment.
@maumar I looked at this again and decided to shelve the ArrayLength changes; I think they're generally good, but it's a bit of extra complexity for no immediate again.
I've put this in a branch, will maybe revisit at some later point...
src/EFCore/Query/Internal/QueryableMethodNormalizingExpressionVisitor.cs
Show resolved
Hide resolved
maumar
approved these changes
Apr 28, 2023
roji
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve array.Length->Count() normalization
Improve indexer->ElementAt normalizationPerform the normalization for core, not just for relational.Integrate it into QueryableMethodNormalizingExpressionVisitorPerform it on indexers on any type that implements IReadOnlyList<>, not just List.