Update MS.CA version & remove hacks #30971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DoctorKrolic I think it's better to wait with this kind of change until we actually target net8.0... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30767 I tried to remove 'target-typed new' hack, but the CI failed. From my investigation it turned out that this error comes from
MS.CA.Analyzerspackage. This package is a dependency ofMS.CA.CSharp.MS.CA.CSharpv4.5.0 depend onMS.CA.Analyzersv3.3.3, but the fix for the hack was introduced only in v3.3.4. Therefore updatingMS.CA.CSharpto v4.6.0 we get desired version of analyzers 3.3.4, so CI here should pass. A few notes:RS1036error, so I was forced to add<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>to analyzers projectMS.CA.CSharpversion, since the minimum version of VS, that supports .NET 8 will probably have bundledMS.CA.CSharp4.8.0 anyway