Add DateOnly.FromDateTime query mapping for SQL Server #31180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
changed the title
roji
reviewed
Jul 4, 2023
There was a problem hiding this comment.
@ErikEJ, looks good thanks.
FYI test test doesn't require a DateOnly in the model, only a DateTime, so it could simply be added to e.g. NorthwindFunctions to avoid adding DateTime to GearsOfWar and changing all the baselines.
Note that it should be pretty easy to implement this for SQLite as well, with the date() function (docs) - are you interested in doing that?
test/EFCore.SqlServer.FunctionalTests/Query/TPTGearsOfWarQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
…SqlServerTest.cs Co-authored-by: Shay Rojansky <roji@roji.org>
|
@roji Should I move the test? |
|
I will leave the SQLite implementation to someone else 😄 |
|
I am moving the test |
|
@ErikEJ pushed a commit that implements for SQLite and asserts failure for Cosmos. |
|
Cool, thanks |
roji
approved these changes
Jul 4, 2023
|
Thanks as always @ErikEJ! |
|
@roji Tag "community-contribution"? |
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30708