-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add infrastructure for trimming and NativeAOT test apps. #31274
Conversation
9f3fe49
to
6d7ee20
Compare
cc @eerhardt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndriySvyryd this is really nice! Is this a copy-paste of the technique used in the runtime for this kind of tests? If so, it may be good to push for making this reusable across the repos (/cc @eerhardt).
I'm confused at the intention here. There are 2 kinds of trimming/aot tests:
Which type of tests are these? If it is the latter (2), then these are going to have to change. You don't put |
Both. The
Why not? Having the |
Because you are conflating the 2 scenarios. In the 2nd scenario, you have multiple |
I don't, the 'Build' target is overridden to do nothing, so VS will just ignore it when building, even if there are compilation errors. |
That's why you don't use a |
You are right, but pragmatically |
It's similar, but I added support for shared files in subfolders and for However, the way it's run differs. For efcore they run during |
Part of #29761
Based on dotnet/aspnetcore#48024
The tests themselves are disabled as there are still lots of warnings that are now treated as errors.