Generate KeyValueFactory and related instances in the compiled model. #33887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
CompiledIdentity
branch
2 times, most recently
from
e651dab
to
e24a704
Compare
Simplify the generated ValueComparers
AndriySvyryd
force-pushed
the
CompiledIdentity
branch
from
e24a704
to
3fed101
Compare
ajcvickers
reviewed
Jun 5, 2024
| providerValueComparer: new ValueComparer<long>( | ||
| (long v1, long v2) => v1 == v2, | ||
| (long v) => ((object)v).GetHashCode(), | ||
| (long v) => v), |
ajcvickers
reviewed
Jun 5, 2024
| @@ -20,7 +20,7 @@ namespace Microsoft.EntityFrameworkCore.ChangeTracking; | |||
| /// </remarks> | |||
| /// <typeparam name="TConcreteCollection">The collection type to create an index of, if needed.</typeparam> | |||
| /// <typeparam name="TElement">The element type.</typeparam> | |||
| public sealed class ListOfReferenceTypesComparer<TConcreteCollection, TElement> : ValueComparer<object> | |||
| public sealed class ListOfReferenceTypesComparer<TConcreteCollection, TElement> : ValueComparer<object>, IInfrastructure<ValueComparer> | |||
There was a problem hiding this comment.
Looks great, but one question: is IInfrastructure<> the right thing to use here? It probably doesn't matter anyway, since it does the right thing.
There was a problem hiding this comment.
It doesn't have the exact semantics, but it's close enough for me to avoid introducing another interface
ajcvickers
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the generated ValueComparers