Refactor design-time tools #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split design-time tools into three packages so that users need only
install "Microsoft.EntityFrameworkCore.Tools" and nuget will restore the
tools they need for the platform they target.
The packages:
- .Tools
- A pseudo-metapackage. This contains shims to call into shared
components.
- lib/net451/Microsoft.EntityFrameworkCore.Tools.dll - Contains
PowerShell cmdlets and APIs that bridge it with common components.
- lib/netcoreapp1.0/dotnet-ef.dll - a light shim for initializing
commands on DotNet project. This executes from "tools".
- lib/netcore50/Microsoft.EntityFrameworkCore.Tools.dll - same as
net451. For compatibility with UWP only. This is never actually
executed.
- build/netcore50/*.target - swaps netcore50 to net451 at build time
on UWP projects
- tools/* - the powershell cmdlets
- .Tools.Cli
- A program to launch commands from dotnet-cli. These execute as a
"dependency".
- lib/netstandard1.5/*.dll - Contains the entry point for executing
commands on a DotNet project model that supports .NET Core
- lib/net451/*.exe - Contains the entry point for executing commands
on a DotNet project modle that supports desktop .NET only
- .Tools.Core
- contains shared components. This contains the implementation
details of executing commands.
This was referenced Apr 21, 2016
natemcmaster
pushed a commit
to aspnet/Coherence
that referenced
this pull request
Apr 21, 2016
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.EntityFrameworkCore.Scaffolding.Internal; | ||
| using Microsoft.EntityFrameworkCore.Design.Internal; |
|
🐑 🇮🇹 |
| => Reporter.Error.WriteLine(message.Bold().Red()); | ||
|
|
||
| protected override void WriteInformation(string message) | ||
| => Reporter.Error.WriteLine(message); |
There was a problem hiding this comment.
Error for writeinformation?
|
⌚ |
|
I've added a new commit to this PR. It includes some response to feedback, cleanup, and fixed up some bugs. |
natemcmaster
changed the title
| { | ||
| var app = new CommandLineApplication() | ||
| { | ||
| Name = "Microsoft.EntityFrameworkCore.Tools.Cli", |
There was a problem hiding this comment.
If this is tied to this assembly you should use a typeof to ensure it stays consistent without needing to manually update.
|
|
| startupConfiguration, | ||
| startupFramework, | ||
| startupBuildBaseDir, | ||
| startupOutputDir) | ||
| buildBasePath: null, |
There was a problem hiding this comment.
Might be good to allow a user to specify some of these so they don't get build output spewed in their current directory.
|
Took a look at the CLI side of things and seemed alright. Lots here though and I'm not 100% fluent in what the EF tooling is responsible for.
|
natemcmaster
added a commit
to aspnet/Coherence
that referenced
this pull request
Apr 25, 2016
This was referenced Apr 26, 2016
natemcmaster
pushed a commit
to aspnet/Diagnostics
that referenced
this pull request
Apr 26, 2016
natemcmaster
pushed a commit
to aspnet/Identity
that referenced
this pull request
Apr 26, 2016
natemcmaster
pushed a commit
to aspnet/Entropy
that referenced
this pull request
Apr 26, 2016
4 tasks
natemcmaster
pushed a commit
to aspnet/Identity
that referenced
this pull request
Apr 26, 2016
natemcmaster
pushed a commit
to aspnet/Diagnostics
that referenced
this pull request
Apr 26, 2016
natemcmaster
pushed a commit
to aspnet/Entropy
that referenced
this pull request
Apr 26, 2016
DotDeveloper95
added a commit
to DotDeveloper95/Entropy
that referenced
this pull request
Sep 4, 2023
DotDeveloper95
added a commit
to DotDeveloper95/Entropy
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split design-time tools into three packages so that users need only install "Microsoft.EntityFrameworkCore.Tools" and nuget will restore the tools they need for the platform they target.
The packages:
components.
PowerShell cmdlets and APIs that bridge it with common components.
commands on DotNet project. This executes from "tools".
net451. For compatibility with UWP only. This is never actually
executed.
on UWP projects
"dependency".
commands on a DotNet project model that supports .NET Core
on a DotNet project modle that supports desktop .NET only
details of executing commands.
Resolves #4577
Resolves #5065
Partial fix for #3925
WIP - remaining work
Functional issues
Cleanup
dotnet restore --infer-runtimeson the tools projects. Without this, dotnet-pack fails, complaining that no runtimes were specified.cc @divega @NTaylorMullen @bricelam