Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Gen.Logging to Avoid LOGGEN036 #5672

Open
dariusclay opened this issue Nov 19, 2024 · 0 comments
Open

Update Microsoft.Gen.Logging to Avoid LOGGEN036 #5672

dariusclay opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
bug This issue describes a behavior which is not expected - a bug.

Comments

@dariusclay
Copy link
Contributor

Description

Issue Description

The source generator from Microsoft.Gen.Logging should be compatible with Microsoft.Extensions.Logging.Abstractions and should not cause warnings or errors for users.

Proposed Solution

Update the source generator in Microsoft.Gen.Logging to avoid triggering LOGGEN036 and similar warnings/errors and ensure compatibility with Microsoft.Extensions.Logging.Abstractions.

Reproduction Steps

https://github.com/vanbukin/ReproExtensions5476/tree/main

Expected behavior

The source generator from Microsoft.Gen.Logging should not trigger warnings or errors and should be compatible with Microsoft.Extensions.Logging.Abstractions.

Actual behavior

Currently, it triggers warnings such as LOGGEN036 : The type "" doesn't implement ToString(), IConvertible..., which breaks builds when treat warnings as errors is enabled.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

Reference discussion in issue #5476.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a behavior which is not expected - a bug.
Projects
None yet
Development

No branches or pull requests

1 participant