Fix aspnet/AspNetCore-Internal#1869 #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the issue here is that the HttpClient goes out of scope too early and the cleanup pass is able to dispose it before we intend for it to be disposed. GC.Keepalive will preserve the liveness until the point we're ready to null it out.
rynowak
commented
Mar 4, 2019
| // the handler from being disposed if it was still rooted. | ||
| Assert.Empty(factory.ActiveEntryState); | ||
|
|
||
| // Act - 1 - Run a cleanup cycle, this will not dispose the handler, because the client is still live. |
There was a problem hiding this comment.
The error is coming from L493 and basically says that L490 was able to dispose the message handler. It's not intended that L490 dispose the message handler, it's supposed to survive this cycle - which implies that client1 been GCed already.
javiercn
approved these changes
Mar 4, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue here is that the HttpClient goes out of scope too
early and the cleanup pass is able to dispose it before we intend for it
to be disposed.
GC.Keepalive will preserve the liveness until the point we're ready to
null it out.