Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AspNetCore.Testing readme, namespaces #4561

Merged
merged 4 commits into from
Oct 20, 2023
Merged

AspNetCore.Testing readme, namespaces #4561

merged 4 commits into from
Oct 20, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Oct 12, 2023 •
edited
Loading

  • Add ReadMe
  • Fix extension method namespaces (and split the class by namespace).
  • Marked APIs as experimental to match the manifest Updated the manifests.
  • Removed a bad dependency reference.
Microsoft Reviewers: Open in CodeFlow

@Tratcher Tratcher added this to the 8.0-rtm milestone Oct 12, 2023
@Tratcher Tratcher self-assigned this Oct 12, 2023
joperezr
joperezr reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and I like the separation as it allows to make sure we get the right namespaces. Just waiting on @geeknoid to confirm on the addition of the experimental attributes.

@joperezr joperezr mentioned this pull request Oct 17, 2023
Closed
Tratcher
Tratcher commented Oct 20, 2023
View reviewed changes
activate.ps1 Outdated Show resolved Hide resolved
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Oct 20, 2023
View reviewed changes
activate.ps1 Outdated Show resolved Hide resolved
@joperezr joperezr enabled auto-merge (squash) October 20, 2023 22:21
joperezr
joperezr approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joperezr joperezr merged commit bd300e7 into dotnet:release/8.0 Oct 20, 2023
6 checks passed
@Tratcher Tratcher deleted the tratcher/readme_asptesting branch October 23, 2023 15:54
@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie left review comments

@danmoseley danmoseley danmoseley left review comments

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@joperezr joperezr joperezr approved these changes

@geeknoid geeknoid geeknoid approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
8.0-rtm
Development

Successfully merging this pull request may close these issues.
6 participants
@Tratcher @RussKie @danmoseley @joperezr @geeknoid @KalleOlaviNiemitalo