Dispose configuration providers #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dispose disposable configuration providers and their change token registrations when disposing the configuration root. - Dispose the change token registration when disposing a FileConfigurationProvider.
davidfowl
reviewed
Jan 10, 2019
ajcvickers
approved these changes
Jan 10, 2019
|
Squashed, rebased (just in case) and adjusted a variable name for consistency.. |
|
@davidfowl Okay to merge now? |
|
LGTM |
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Feb 28, 2020
…sions#928) - Dispose disposable configuration providers and their change token registrations when disposing the configuration root. - Dispose the change token registration when disposing a FileConfigurationProvider. Commit migrated from dotnet/extensions@95577f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 2, 2020
…sions#928) - Dispose disposable configuration providers and their change token registrations when disposing the configuration root. - Dispose the change token registration when disposing a FileConfigurationProvider. Commit migrated from dotnet/extensions@95577f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 11, 2020
…sions#928) - Dispose disposable configuration providers and their change token registrations when disposing the configuration root. - Dispose the change token registration when disposing a FileConfigurationProvider. Commit migrated from dotnet/extensions@95577f5
maryamariyan
pushed a commit
to maryamariyan/runtime
that referenced
this pull request
Mar 27, 2020
…sions#928) - Dispose disposable configuration providers and their change token registrations when disposing the configuration root. - Dispose the change token registration when disposing a FileConfigurationProvider. Commit migrated from dotnet/extensions@95577f5
1 task
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the Extensions.Configuration side of #861. The next step would be to actually dispose the configuration root inside the WebHost. I’ll attempt a PR for that later.
With this, I’ve also fixed the leak that @HaoK mentioned in #868 (comment).
cc @davidfowl