Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F# code in Visual Studio 2015 has Keep Tabs = true #199

Closed
dsyme opened this issue Feb 1, 2015 · 12 comments
Closed

F# code in Visual Studio 2015 has Keep Tabs = true #199

dsyme opened this issue Feb 1, 2015 · 12 comments
Labels
Milestone

Comments

@dsyme
Copy link
Contributor

dsyme commented Feb 1, 2015

I installed Visual Studio 2015 CTP5 without any particular change of settings. F# code seems to have Keep Tabs = true by default. This should be false

capture

@dsyme
Copy link
Contributor Author

dsyme commented Feb 1, 2015

It would be good if someone could verify if this not just some quirk of my machine

@dungpa
Copy link
Contributor

dungpa commented Feb 3, 2015

My installation shows "Insert spaces" as the default option.

@dsyme
Copy link
Contributor Author

dsyme commented Feb 4, 2015

Well, that's strange. I can't imagine why mine would be showing "TABs"....

@rojepp
Copy link
Contributor

rojepp commented Feb 5, 2015

@dsyme Could it be that it inherited from 'All languages' when updating?

@enricosada
Copy link
Contributor

i tried using a new azure vm (the vs 2015 ctp from gallery), is ok for me ( insert spaces )

The default of All Languages is not set

@dsyme
Copy link
Contributor Author

dsyme commented Feb 5, 2015

I'll close this for now since no one else can repro. But let's keep an eye on this - there must be some logical explanation for how I got the Tabs setting on my machine.

@enricosada
Copy link
Contributor

@latkin reopen this one so?
If you have ideas about how to procede. There is an vs installation log?

@enricosada
Copy link
Contributor

@latkin can you reopen this one pls? the other is a duplicate, but i have this issue in my installation (VS2015 RC see #413 )

Also the c# file configuration is the same, with insert tabulation instead of space

@latkin
Copy link
Contributor

latkin commented May 28, 2015

I do see this in clean test installs, as well.

Weird because in the settings file for the General profile (which I think is inherited by the F# profile) there is explicit config for F# language to use spaces, not tabs. I will try to poke around a bit, that config is part of closed VS platform code.

@latkin latkin reopened this May 28, 2015
@latkin latkin added this to the VS 2015 milestone May 28, 2015
@enricosada
Copy link
Contributor

@latkin Take a look at c# page too. Default is tabs there instead of spaces ( wrong )

Maybe you can also raise the priority because is really bad. New file, write write and doesnt work.
Is difficult to understand is a tabs vs spaces problem. For new user is really difficult

@jcansdale
Copy link

Does the F# compiler treat a single tab as being equal to a space?

On 28 May 2015 at 18:24, Enrico Sada notifications@github.com wrote:

@latkin https://github.com/latkin Take a look at c# page too. Default
is tabs there instead of spaces ( wrong )

Maybe you can also raise the priority because is really bad. New file,
write write and doesnt work.
Is difficult to understand is a tabs vs spaces problem. For new user is
really difficult


Reply to this email directly or view it on GitHub
#199 (comment)
.

@enricosada
Copy link
Contributor

Tabs are compile time error

@latkin latkin added bar-check and removed pri-3 labels Jun 1, 2015
latkin added a commit to latkin/visualfsharp that referenced this issue Jun 9, 2015
On package load, check if any of the custom F# settings are somehow missing
from the settings store.  Explicitly set them to their desired defaults if
they are indeed missing.

I've added this to the language service package since this is guaranteed
to load any time the project system package is loaded, but the converse is
not true (e.g. open loose F# script file without opening a solution).

fixes dotnet#199
latkin added a commit to latkin/visualfsharp that referenced this issue Jun 9, 2015
On package load, check if any of the custom F# settings are somehow missing
from the settings store.  Explicitly set them to their desired defaults if
they are indeed missing.

I've added this to the language service package since this is guaranteed
to load any time the project system package is loaded, but the converse is
not true (e.g. open loose F# script file without opening a solution).

fixes dotnet#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants