"Internal error or badly formatted metadata"

[matthid]

Continuation of ionide/ionide-vscode-fsharp#912

Ionide:

VS 2017:

open Microsoft.Extensions.Logging
open System

let provider =
    { new ILoggerProvider with
        member x.Dispose() = ()
        member x.CreateLogger name =
            { new ILogger with
                member x.Log<'TState>(logLevel: LogLevel, eventId : EventId, state: 'TState, exception: exn, formatter: Func<'TState, exn, string>) =
                    ()
                member x.IsEnabled (logLevel:LogLevel ) = true
                member x.BeginScope<'TState> (State: 'TState) =
                    { new IDisposable with
                        member x.Dispose() = () } } }

Repro steps

Paste the above code into your project and install the Microsoft.Extensions.Logging NuGet package

Expected behavior

Only "exception" should be underlined and the error message should be:

Actual behavior

"Internal error" is shown to the user

Known workarounds

None. Notice that you used an keyword.

Related information

Provide any related information

• Operating system: Windows 10
• .NET Runtime, CoreCLR or Mono Version: Would assume all?
• Editing Tools (e.g. Visual Studio Version): Ionide + VS 15.7.5
• Indications of severity: Annoyance & Adoption (Problem for beginners)

[cartermp]

Thanks, agreed on what the error should be.

Hey @TIHan

[dsyme]

This is niche enough that I'm going to close this - exception is rarely used and the awkward diagnostic hasn't been seen in other cases.