Reduce intermediate collections in type checker #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match nameSearch with | ||
| | None -> None | ||
| | Some nm -> Some (nm, maintainsVarSpaceUsingBind, maintainsVarSpace, allowInto, isLikeZip, isLikeJoin, isLikeGroupJoin, joinConditionWord, methInfo)) | ||
| if IsMethInfoAccessible cenv.amap mBuilderVal ad methInfo then |
There was a problem hiding this comment.
maybe for this one, invert if to minimize diff?:
if not (IsMethInfoAccessible cenv.amap mBuilderVal ad methInfo) then None
else
// same indentation as before
There was a problem hiding this comment.
Yes, that would be helpful. Or sometimes I locally switch to two-space indent to minimize the diff (and then submit a separate cleanup later if needed)
|
@vasily-kirichenko it's an @dsyme thing. I get told off about it all of the time. This link does the diff without whitespace changes. https://github.com/Microsoft/visualfsharp/pull/1213/files?w=1 By all means continue to improve readability: Just edit the comment to include a link to the files with |
|
That link is very helpful :) This is good to go in, we can merge it. |
|
@forki Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to files with whitespace ignored:
https://github.com/Microsoft/visualfsharp/pull/1213/files?w=1