Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC FS-1123 Result module parity with Options #13326

Merged
merged 3 commits into from
Jun 20, 2022
Merged

RFC FS-1123 Result module parity with Options #13326

merged 3 commits into from
Jun 20, 2022

Conversation

uxsoft
Copy link
Contributor

@uxsoft uxsoft commented Jun 18, 2022

RFC FS-1123 Result module parity with Options

Suggestion: fsharp/fslang-suggestions#1123
RFC: https://github.com/fsharp/fslang-design/blob/main/FSharp-7.0/FS-1123-result-module-parity-with-option.md

  • Implementation
  • Tests
  • Examples

Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@KevinRansom KevinRansom requested a review from dsyme June 18, 2022 23:58
@vzarytovskii
Copy link
Member

vzarytovskii commented Jun 19, 2022

We need to merge RFC first, I guess, in case there are some changes requested. But otherwise looks good to me too.

Thanks!

@uxsoft
Copy link
Contributor Author

uxsoft commented Jun 19, 2022

We need to merge RFC first, I guess, in case there are some changes requested. But otherwise looks good to me too.

Thanks!

Merged RFC here: https://github.com/fsharp/fslang-design/blob/main/FSharp-7.0/FS-1123-result-module-parity-with-option.md

@vzarytovskii vzarytovskii merged commit 70ad2e5 into dotnet:main Jun 20, 2022
@uxsoft uxsoft deleted the feature/result-module-parity branch June 22, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants