Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8914 and 5986 #16817

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix 8914 and 5986 #16817

merged 3 commits into from
Mar 7, 2024

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Mar 6, 2024

Fixes #8914 None Update ignored in F# projects
Fixes #5986 Globbing not supported for content in fsproj

This PR enables Content and Resources

@KevinRansom KevinRansom requested a review from a team as a code owner March 6, 2024 01:04
Copy link
Contributor

github-actions bot commented Mar 6, 2024

✅ No release notes required

@psfinaki psfinaki changed the title Fix 8914 Fix 8914 and 5986 Mar 6, 2024
@psfinaki
Copy link
Member

psfinaki commented Mar 6, 2024

Any way to test this? I tried testing it from this branch manually but don't see any effect. But maybe I am doing something wrong.

@KevinRansom KevinRansom merged commit 35e5347 into dotnet:main Mar 7, 2024
31 checks passed
@KevinRansom KevinRansom deleted the Fix8914 branch March 21, 2024 22:24
@KevinRansom
Copy link
Member Author

KevinRansom commented Mar 26, 2024

I am reverting this fix and add a comment. globbing include None, can change the display of F# projects, by modifying folder order, and by displaying all .fsi files in a group before all .fs files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None Update ignored in F# projects Globbing not supported for content in fsproj
4 participants