Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary code introduced in #16779 #17154

Merged
merged 2 commits into from
May 16, 2024

Conversation

majocha
Copy link
Contributor

@majocha majocha commented May 16, 2024

Some cleanup following the AsyncLocal stuff.

This code is most probably unneeded, because this now happens in Async.RunImmediate.

Copy link
Contributor

github-actions bot commented May 16, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha majocha marked this pull request as ready for review May 16, 2024 10:03
@majocha majocha requested a review from a team as a code owner May 16, 2024 10:03
@majocha
Copy link
Contributor Author

majocha commented May 16, 2024

@psfinaki, just as you noticed in the review, this is duplication. If it's green, it can be safely removed.

I think release notes not needed.

@psfinaki psfinaki added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 16, 2024
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jakub :)

@psfinaki psfinaki enabled auto-merge (squash) May 16, 2024 10:30
@psfinaki psfinaki merged commit ecf7101 into dotnet:main May 16, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants