[CompilerPerf] Remove unbox.any when coercing to subsumed interfaces #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
May 2, 2017
src/fsharp/IlxGen.fs
Outdated
| if (isInterfaceTy cenv.g tgty) then ( | ||
| GenExpr cenv cgbuf eenv SPSuppress e Continue | ||
| let ilToTy = GenType cenv.amap m eenv.tyenv tgty | ||
| CG.EmitInstrs cgbuf (pop 1) (Push [ilToTy]) [ I_unbox_any ilToTy ] | ||
| // I believe section "III.1.8.1.3 Merging stack states" of ECMA-335 implies that no unboxing |
There was a problem hiding this comment.
Can you please reformulate this to remove the "I"? Thx
There was a problem hiding this comment.
haha, well I was hoping someone who confirm that, and then it wouldn't be total based on my potentially misaken belief!
src/fsharp/IlxGen.fs
Outdated
| CG.EmitInstrs cgbuf (pop 1) (Push [ilToTy]) [ I_unbox_any ilToTy ] | ||
| // I believe section "III.1.8.1.3 Merging stack states" of ECMA-335 implies that no unboxing | ||
| // is required, but we still push the coerce'd type on to the code gen buffer. | ||
| CG.EmitInstrs cgbuf (pop 1) (Push [ilToTy]) [ (*I_unbox_any ilToTy*) ] |
There was a problem hiding this comment.
Please remove the commented code directly.
|
looks like it touched IL test. so that's a good thing I guess |
dsyme
approved these changes
May 2, 2017
|
Approved once test is fixed - thanks for doing this |
KevinRansom
approved these changes
May 2, 2017
|
@manofstick |
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 3, 2017
11 tasks
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 7, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 8, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 8, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 9, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 13, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 13, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 15, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 17, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
May 18, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Jun 22, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Jun 22, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Aug 16, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Aug 17, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Sep 12, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Sep 12, 2017
manofstick
added a commit
to manofstick/visualfsharp
that referenced
this pull request
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented upon here and manually avoided in #2587 (Such as this) this PR removes the IL instruction
unbox.anyfromupcasts to interface types.Previously code like:
Would insert the upcast.any statement into the result of both branches, but from my reading of "III.1.8.1.3 Merging stack states" of ECMA-335 the runtime automatically will merge the stacks to the common subtype. This appears to be borne out in practice.
This PR will simplify the #2587 by removing all the manual Upcast hacks that are done.