Fix #486 - restore binary compat for inline resource API

[latkin]

• Bug number F# Interactive v14 backward incompatibility: Error FS0193 when calling inlined Array.init #486
• Customer scenario

Internal error when consuming some F# 3.X libraries in F# 4.0 REPL, due to binary compat break.

Compat break was introduced in fix for loc issue #159. Restoring compat means this bug is now re-introduced.

• Fix description
  • Restore old code in the resource API with the compat break
  • Do best-effort at keeping localization fix intact where possible
    • Loc issue is now restricted only to inline functions. The busted resource API was intended for use only by inline functions, but it had crept in to non-inline functions, as well. This is now corrected, so original localization issue is minimized as much as possible.
• Testing done Cross-version compiler tests added, covering functions that use these resource APIs

[latkin]

ping @dsyme @enricosada to review. AFAICT switch to SR.GetString( ... ) in non-inline functions should be safe/correct and maintain localization fix where possible.

[dsyme]

Yes, LGTM. Thanks to both of you for your diligence and efforts on this

[enricosada]

good job @latkin , didn't think about other functions using ErrorStrings, LGTM

[MattGertz]

MoreInfo 6/12 by ML Shiproom. @latkin Rollback for next release, full fix for go-ahead repo.

[latkin]

Shiproom has requested that this be scoped purely to rollback of the binary compat issue. I've removed the partial loc fixes.