Blob heap size #519
Closed
Blob heap size #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latkin
pushed a commit
that referenced
this pull request
Aug 7, 2015
Obfuscated assemblies can have a bogus extra reference to mscorlib which has incorrect index in Blob heap for HashValue - index value was out of range of the heap.I guess the assumption was that compiler will not try to realize the whole set of information for this AssemblyRef entry but decompiler will try to do. The problem was that F# compiler is eagerly trying to populate information about referenced assemblies for the given assembly so it crashes during the attempt to read this malformed entry. fixes #517 closes #519 commit 326a7fc Author: Vladimir Matveev <vladima@microsoft.com> Date: Wed Jul 1 00:27:11 2015 -0700 added tests commit 1d8dd07 Author: Vladimir Matveev <vladima@microsoft.com> Date: Mon Jun 29 00:14:27 2015 -0700 fix incorrect condition commit 0c0c696 Author: Vladimir Matveev <vladima@microsoft.com> Date: Sun Jun 28 23:30:38 2015 -0700 added range check to readBlobHeapUncached
|
Applied to OOB branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517