-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smal fixes for https://github.com/Microsoft/visualfsharp/pull/5940 #5943
Conversation
Issues:
Looks like the same failing test in other CI runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AviAvni
@dsyme the code for this doesn't appear to have a test for correctness. Any ideas on adding a regression test for this? |
IIRC this code was added to FCS and there were normally tests added for everything we did there. So the FCS tests would be the right place |
Small fixes according to @blumu review