[FS-1080] Add new syntax option for Float32.

[gdziadkiewicz]

Suggestion: fsharp/fslang-suggestions#750
RFC: https://github.com/fsharp/fslang-design/blob/master/FSharp-5.0/FS-1080-float32-without-dot.md

[cartermp]

Thanks for the trial implementation @gdziadkiewicz - I've tagged this as Needs RFC. If either you or @abelbraaksma submits a PR that is approved, we'll remove the tag.

[cartermp]

@TIHan @dsyme @KevinRansom can you please take a look?

[TIHan]

Implementation is great.

The one thing missing is locking the feature to a language version and having tests cover that. This is partly our fault as we need better ways to handle language version in our tests. I have to do this anyway with the 'default interface method consumption' feature, so I may work a lot on tests this week.

[gdziadkiewicz]

@TIHan Then I will wait for your work to copy the approach.

[dsyme]

Agreed with @TIHan - just needs the language version implementation

[KevinRansom]

This is nice, lang version might be a bit tricky.

[KevinRansom]

Okay Lexbuffer<'Char> has supportsLanguageVersion:

https://github.com/dotnet/fsharp/blob/release/fsharp5/src/utils/prim-lexing.fsi#L112

And it's available right here:

fsharp/src/fsharp/lex.fsl

Line 338 in cad335e

| ieee32

So I guess not so tricjky,

[gdziadkiewicz]

@TIHan Can you check my approach to the language version?

[cartermp]

@KevinRansom can also take a look, he did the fun work of backporting LangVersion into various merged features for F# 4.7 🙂

[cartermp]

Looks good overall, some minor quibbles

[gdziadkiewicz]

@cartermp Is there anything more that I should do?

[cartermp]

This looks good @gdziadkiewicz, thanks! We'll need review from @dsyme to see this merged, though.

[dsyme]

LGTM

[cartermp]

@gdziadkiewicz looks like there's some conflicts, but directly fixing them may cause a build break. Could you take care of that? After that's done we'll merge this in. Great work, and thanks for the patience!

[KevinRansom]

Looks great. I'm going to move it to fsharp5 with all of the other fsharp5 language features. However, that is all coming back to master shortly.

Taken care of by author.

[abelbraaksma]

@gdziadkiewicz, the link in the original post gives a 404, was it moved? Incorrect: https://github.com/fsharp/fslang-design/blob/master/RFCs/FS-1080-float32-without-dot.md.

[Happypig375]

@abelbraaksma https://github.com/fsharp/fslang-design/blob/master/preview/FS-1080-float32-without-dot.md

[abelbraaksma]

@Happypig375, thanks. I've reported the underlying issue that we ought to expect all RFCs to be in one place, or be redirected if moved.